stmtdiagnostics: remove unused JSON trace datum #65583
Conversation
|
This change is |
There was a problem hiding this comment.
Haha, noooooo! You are removing the traces from the bundle, which are super useful. 2d05a54 stopped writing it to the system table, not the bundle.
Reviewable status:
complete! 0 of 0 LGTMs obtained
There was a problem hiding this comment.
Reviewable status:
pkg/sql/explain_bundle.go, line 167 at r1 (raw file):
b.addDistSQLDiagrams() b.addExplainVec() traceJSON := b.addTrace()
I see - I need to remove unused local variable traceJSON - my bad, will update shortly.
yuzefovich
changed the title
In 2d05a54 we stopped writing JSON trace datums to the system table, but some remnants of that work still remained. This commit cleans that up. Release note: None
There was a problem hiding this comment.
Updated, PTAL.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status:
|
TFTR! bors r+ |
|
Build succeeded: |
In 2d05a54 we stopped writing JSON
trace datums to the system table, but some remnants of that work still
remained. This commit cleans that up.
Release note: None