sql: instantiate metrics for internal sql stats #65575
Merged
+67
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
May 21, 2021
There was a problem hiding this comment.
Okay :/
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
rafiss
requested changes
May 21, 2021
rafiss
reviewed
May 21, 2021
Azhng
force-pushed
the
add-internal-sql-stats-metrics
branch
from
eaf1a71 to
7cdf7bb
Compare
Azhng
commented
May 21, 2021
There was a problem hiding this comment.
The randomized test failed because this bug is only trigger when the amount of fingerprint exceeded either the cluster setting limit or the memory limit.
I added a test to catch this.
Reviewable status:
rafiss
approved these changes
May 21, 2021
Previously, we did not instantiate metrics for internal SQL stats. However, this can cause issues when connExecutor is being created by InternalExecutor. In order to address this, we also instantiate metrics for internal stats. Release note: None Closes cockroachdb#65523
Azhng
force-pushed
the
add-internal-sql-stats-metrics
branch
from
7cdf7bb to
0955915
Compare
|
Hmm, bazel is not happy. Rebased see if that address the problem. |
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we did not instantiate metrics for internal SQL stats.
However, this can cause issues when connExecutor is being created
by InternalExecutor. In order to address this, we also instantiate
metrics for internal stats.
Release note: None
Closes #65523