kvserver: simplify TestClosedTimestampInactiveAfterSubsumption #65443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#59448 This patch moves the test away from using the "old closed timestamp mechanism" to using the new one. The test becomes simpler in the process, and does not appear to be flaky any more (the test was skipped). Release note: None
|
This change is |
aayushshah15
approved these changes
May 19, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)
pkg/kv/kvserver/closed_timestamp_test.go, line 715 at r1 (raw file):
// Sleep a bit and assert that the closed timestamp has not advanced while // we were sleeping. time.Sleep(time.Second)
nit: is it worth it to make this a multiple of the side transport's close interval?
andreimatei
commented
May 24, 2021
There was a problem hiding this comment.
moved this into #65624. Please check it out there.
Reviewable status:
pkg/kv/kvserver/closed_timestamp_test.go, line 715 at r1 (raw file):
Previously, aayushshah15 (Aayush Shah) wrote…
nit: is it worth it to make this a multiple of the side transport's close interval?
done
andreimatei
deleted the
closedts.simplify-TestClosedTimestampInactiveAfterSubsumption
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59448
This patch moves the test away from using the "old closed timestamp
mechanism" to using the new one. The test becomes simpler in the
process, and does not appear to be flaky any more (the test was
skipped).
Release note: None