Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: pgwire: fix decoding of binary TimeTZ values #65341

Merged
merged 1 commit into from
May 25, 2021

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented May 17, 2021

Backport 1/2 commits from #65063.

/cc @cockroachdb/release


Release note (bug fix): Binary TimeTZ values were not being decoded
correctly when being sent as a parameter in the wire protocol. This
is now fixed.

@rafiss rafiss requested review from otan and a team May 17, 2021 17:06
@rafiss rafiss requested a review from a team as a code owner May 17, 2021 17:06
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if this is too risky for backporting to v21.1
i think the only change should go in is in pkg/sql/pgwire/pgwirebase/encoding.go, which should go all the way to 20.1/20.2.

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops wrong button

Release note (bug fix): Binary TimeTZ values were not being decoded
correctly when being sent as a parameter in the wire protocol. This
is now fixed.
@rafiss rafiss force-pushed the backport21.1-65063 branch from ea5485b to 0828aaf Compare May 21, 2021 21:42
@blathers-crl blathers-crl bot requested a review from otan May 21, 2021 21:42
@rafiss rafiss changed the title release-21.1: pgwire: only show TZ minutes offset if non-zero release-21.1: pgwire: fix decoding of binary TimeTZ values May 21, 2021
@rafiss
Copy link
Collaborator Author

rafiss commented May 21, 2021

alrighty, @otan ready for another review!

@rafiss rafiss requested review from a team and removed request for a team May 24, 2021 15:29
@rafiss rafiss merged commit c768554 into cockroachdb:release-21.1 May 25, 2021
@rafiss rafiss deleted the backport21.1-65063 branch May 25, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants