release-21.1: sql: fix Usage privilege on Tables/DBs after upgrading from 20.1 #65160
Conversation
RichardJCai
requested review from
a team and
nihalpednekar
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
The thing I find surprising about these commits is that they do not have a release note.
Reviewed 4 of 4 files at r1, 4 of 16 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner, @nihalpednekar, and @pbardea)
True, when I wrote it, I thought there wasn't anything that was needed to write on the docs side, but thinking about it now, I'll add a bug fix release note. |
In 20.2, I made a mistake when introducing USAGE privilege by adding it before ZONECONFIG privilege in the bitfield. Due to this, when updating from 20.1 to 20.2, ZONECONFIG privilege will be interpretted as USAGE. Fortunately, ZONECONFIG was only a valid privilege on tables and databases while USAGE is invalid on both those objects. Due to this, whenever we encounter USAGE on a privilege descriptor versioned 20.1 (InitialVersion) we can fix this by removing the bit for USAGE and adding the bit for ZONECONFIG on the privilege descriptor. Release note (bug fix): When updating from 20.1 to 20.2, the ZONECONFIG privilege on Tables/Databases will be incorrectly interpretted as USAGE causing the table/database to be corrupted because USAGE is invalid on tables and databases. This bug fix ensures the ZONECONFIG bit will continue to be interpretted as ZONECONFIG in 20.2 and onwards ensuring the tables and databases with ZONECONFIG are not corrupted and have the correct privilege.
… prior. This is needed in addition to the previous commit to fix ZONECONFIG privilege when restoring from a version from 20.1 or prior. Release note (bug fix): Fix case when ZONECONFIG privilege would be incorrectly restored as USAGE privilege for Tables/Databases created and backed up in 20.1 or prior and restored through a full cluster restore in a 20.2 or later version.
RichardJCai
force-pushed
the
backport21.1-65010
branch
from
e673446 to
f0fc849
Compare
Updated release notes. |
Backport 2/2 commits from #65010.
/cc @cockroachdb/release
In 20.2, I made a mistake when introducing USAGE privilege by
adding it before ZONECONFIG privilege in the bitfield.
Due to this, when updating from 20.1 to 20.2, ZONECONFIG privilege will be
interpretted as USAGE.
Fortunately, ZONECONFIG was only a valid privilege on tables and databases
while USAGE is invalid on both those objects. Due to this, whenever we encounter
USAGE on a privilege descriptor versioned 20.1 (InitialVersion) we can fix
this by removing the bit for USAGE and adding the bit for ZONECONFIG on the
privilege descriptor.
Release note (bug fix): When updating from 20.1 to 20.2, the ZONECONFIG
privilege on Tables/Databases will be incorrectly interpretted as
USAGE causing the table/database to be corrupted because USAGE is
invalid on tables and databases. This bug fix ensures the ZONECONFIG bit
will continue to be interpretted as ZONECONFIG in 20.2 and onwards
ensuring the tables and databases with ZONECONFIG are not corrupted
and have the correct privilege.
Release note (bug fix): Fix case when ZONECONFIG privilege would be incorrectly
restored as USAGE privilege for Tables/Databases created and backed up in 20.1
or prior and restored through a full cluster restore in a 20.2 or later version.