sql: changed pg_catalog data type columns to "char" to match postgres #65101
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
blathers-crl
bot
added
O-community
|
This change is |
There was a problem hiding this comment.
Change looks good to me, but looks like this is breaking a few tests that might need updating. Also, could you add that this change is backwards incompatible in the release note?
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rafiss)
mnovelodou
force-pushed
the
pg_catalog_test_to_char
branch
from
9eca599 to
238b865
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There was a problem hiding this comment.
The "backwards-incompatible-change" should go where the sql change goes, so `Release note (backwards-incompatible change). Also, could you add the fact that these columns were previously of type TEXT but have now been changed to "char" in the release note as well?
Once you update the commit message, I can bors this!
Reviewable status:
Previously, some columns where is expected "char" datatype it is created as TEXT This was inadequate because some tools are expecting these columns to have "char" datatype To address this, this patch change the data types from these columns Release note (backward-incompatible change): Switched types from TEXT to "char" for compatibility with postgres in the following columns: pg_constraint (confdeltype, confmatchtype, confudptype, contype) pg_operator (oprkind) pg_prog (proargmodes) pg_rewrite (ev_enabled, ev_type) pg_trigger (tgenabled) Fixes cockroachdb#64434
mnovelodou
force-pushed
the
pg_catalog_test_to_char
branch
from
238b865 to
83790f6
Compare
|
Thanks! bors r+ |
|
Build succeeded: |
Previously, some columns where is expected "char" datatype
it is created as TEXT
This was inadequate because some tools are expecting these
columns to have "char" datatype
To address this, this patch change the data types from these
columns
Release note (backward-incompatible change): Switched types from TEXT
to "char" for compatibility with postgres in the following columns:
pg_constraint (confdeltype, confmatchtype, confudptype, contype)
pg_operator (oprkind)
pg_prog (proargmodes)
pg_rewrite (ev_enabled, ev_type)
pg_trigger (tgenabled)
Fixes #64434