schemaexpr: remove unnecessary structs #65100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit removes `schemaexpr.ComputedColumnValidator`. The struct's methods did not store any state in the struct, so they have been converted to functions without a receiver. Release note: None
This commit removes `schemaexpr.IndexPredicateValidator`. The struct's methods did not store any state in the struct, so they have been converted to functions without a receiver. Release note: None
mgartner
force-pushed
the
remove-schemaexpr-structs
branch
from
b7d9c42 to
1c40f61
Compare
|
Friendly ping. |
RaduBerinde
approved these changes
May 17, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @postamar)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schemaexpr: remove ComputedColumnValidator struct
This commit removes
schemaexpr.ComputedColumnValidator. The struct'smethods did not store any state in the struct, so they have been
converted to functions without a receiver.
Release note: None
schemaexpr: remove IndexPredicateValidator struct
This commit removes
schemaexpr.IndexPredicateValidator. The struct'smethods did not store any state in the struct, so they have been
converted to functions without a receiver.
Release note: None