Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: randomly run sinkless tests on tenant #65056

Merged
merged 2 commits into from
May 21, 2021

Conversation

stevendanna
Copy link
Collaborator

@stevendanna stevendanna commented May 12, 2021

Now, sinkless tests will run against a tenant's SQL server 25% of the
time, unless they opt-out via an option.

The main two reasons for tests needing to opt-out of running on
tenants are

  1. Unsupported SQL statements in mutli-tenant mode (such as REGION
    related statements or SPLIT)

  2. Needing complex interactions with the TestServerInterface. All such
    skips are currently marked with a TODO.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stevendanna stevendanna requested review from miretskiy and HonoreDB May 12, 2021 14:21
@stevendanna
Copy link
Collaborator Author

stevendanna commented May 12, 2021

I'll rebase on top of the test refactor if that merges first. Done.

@stevendanna stevendanna force-pushed the ssd/cdc-random-tenant-tests branch from bd59d74 to 9b21a99 Compare May 12, 2021 15:06
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 12, 2021

CLA assistant check
All committers have signed the CLA.

@stevendanna stevendanna changed the base branch from ssd/changefeed-tenant-tests to master May 12, 2021 15:06
Now, sinkless tests will run against a tenant's SQL server 25% of the
time, unless they opt-out via an option.

The main two reasons for tests needing to opt-out of running on
tenants are

1) Unsupported SQL statements in mutli-tenant mode (such as REGION
   related statements or SPLIT)

2) Needing complex interactions with the TestServerInterface. All such
   skips are currently marked with a TODO.

Release note: None
UseDatabase is used in the changefeed tests to connect to a particular
database during the tests.

Release note: None
@stevendanna stevendanna force-pushed the ssd/cdc-random-tenant-tests branch from 9b21a99 to 600b64b Compare May 21, 2021 08:55
@stevendanna
Copy link
Collaborator Author

bors r=miretskiy

@craig
Copy link
Contributor

craig bot commented May 21, 2021

Build succeeded:

@craig craig bot merged commit 41756ef into cockroachdb:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants