sql/pgwire: change formatting of floating point infinity values

[iAziz786]

Fixes #62601

Postgres drivers such as JDBC rely on infinite values to be
formatted as full words in order to be able to parse the
value.

Release note (sql change): Floating point infinity values are now
formatted as Infinity (or -Infinity if negative). This is for
compatibility with Postgres.

[cockroach-teamcity]

All committers have signed the CLA.

[blathers-crl]

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

• Please ensure your git commit message contains a release note.
• When CI has completed, please ensure no errors have appeared.

I have added a few people who may be able to assist in reviewing:

• @rafiss (commented on Cannot read floating point infinity values from JDBC #62601)

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[cockroach-teamcity]

This change is 

[iAziz786]

@rafiss I ran the test cases but for some reason, they were not hitting func (d *DFloat) Format. When I add fmt.Println into that function I only saw one log. Anything am I missing?

[rafiss]

@iAziz786 sorry for misdirecting you! it looks like the change to func (d *DFloat) Format is not necessary.

instead, this change needs to be done in pkg/sql/pgwire/types.go writeTextDatum in the DFloat case.

[blathers-crl]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[iAziz786]

@rafiss made the suggested changes, and make test PKG=./pkg/sql/pgwire TESTS=TestEncodings is passing as well. Should I move this PR from draft to ready for review?

There is something strange though when I run the command mentioned in the #62601 I'm getting the same result as before.

[rafiss]

That's interesting -- it looks like it's because the CLI has extra parse/format logic so that it displays the value as a golang infinity. if you connect with the psql tool (e.g. psql -h localhost -p 26257 -U root -w -d defaultdb), you should see your change in effect

this likely also explains why our other SQL tests are not affected by your change.

yes, please make this ready to review. before that, you will need to update the commit message (and PR message) to have a proper release note. See https://wiki.crdb.io/wiki/spaces/CRDB/pages/186548364/Release+notes

also, the title of the commit message should be adjusted. cockroachdb already supports infinity values -- this is just changing the formatting. see https://wiki.crdb.io/wiki/spaces/CRDB/pages/73072807/Git+Commit+Messages

so a full commit message could be:

sql/pgwire: change formatting of floating point infinity values

Postgres drivers such as JDBC rely on infinite values to be
formatted as full words in order to be able to parse the
value.

Release note (sql change): Floating point infinity values are now
formatted as `Infinity` (or `-Infinity` if negative). This is for
compatibility with Postgres

Thanks for your work here! This is almost ready to go.

[iAziz786]

Yes, it's working as you have mentioned. 💯

Your version of the commit message is a lot better than what I could have written so I used the same.

[rafiss]

thank you for your contribution!

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)