Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: upgrade to bazel 4.0.0 in the builder image #64732

Merged
merged 1 commit into from
May 6, 2021

Conversation

rickystewart
Copy link
Collaborator

This will allow us to pick up the latest version of rules_foreign_cc,
(for example, for #64334) which doesn't build with an earlier bazel
(#64709). Also make sure the version assertion in WORKSPACE is
up-to-date.

Release note: None

This will allow us to pick up the latest version of `rules_foreign_cc`,
(for example, for cockroachdb#64334) which doesn't build with an earlier bazel
(cockroachdb#64709). Also make sure the version assertion in `WORKSPACE` is
up-to-date.

Release note: None
@rickystewart rickystewart requested a review from rail May 5, 2021 18:57
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)

@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented May 6, 2021

Build succeeded:

@craig craig bot merged commit 84c450e into cockroachdb:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants