issues: improve random syntax test crash reports #64490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Nice, I'll take a look on Tuesday (off on Monday)! |
|
Cc @cockroachdb/test-eng |
tbg
approved these changes
May 4, 2021
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
mgartner
force-pushed
the
improve-rsg-test-failure-report
branch
from
02cb403 to
09e5a35
Compare
Crashes during random syntax tests now report more useful information to
the issue including the error message, the SQL that produced the error,
and the database schema.
The report will be formatted as:
> Random syntax error:
>
> ```
> rsg_test.go:755: Crash detected: server panic: pq: internal error: something bad
> ```
> Query:
>
> ```
> SELECT
> foo
> FROM
> bar
> LIMIT
> 33:::INT8;
> ```
> Schema:
>
> ```
> rsg_test.go:575: To reproduce, use schema:
> rsg_test.go:577:
> CREATE TABLE table1 (col1_0 BOOL);
> ;
> rsg_test.go:577:
>
> CREATE TYPE greeting AS ENUM ('hello', 'howdy', 'hi', 'good day', 'morning');
> ;
> rsg_test.go:579:
> rsg_test.go:580: -- test log scope end --
> test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestRandomSyntaxSQLSmith460792454
> --- FAIL: TestRandomSyntaxSQLSmith (300.69s)
> ```
Release note: None
mgartner
force-pushed
the
improve-rsg-test-failure-report
branch
from
09e5a35 to
dd708c7
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crashes during random syntax tests now report more useful information to
the issue including the error message, the SQL that produced the error,
and the database schema.
The report will be formatted as:
Release note: None