Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/sqlproxyccl: fix a broken test in bazel #64441

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

darinpp
Copy link
Contributor

@darinpp darinpp commented Apr 29, 2021

This fixes #61915
by adding the required data files.

Release note: None

This fixes cockroachdb#61915
by adding the required data files.

Release note: None
@darinpp darinpp requested a review from rickystewart April 29, 2021 23:10
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@darinpp
Copy link
Contributor Author

darinpp commented Apr 29, 2021

bazel test pkg/ccl/sqlproxyccl:sqlproxyccl_test
INFO: Analyzed target //pkg/ccl/sqlproxyccl:sqlproxyccl_test (3 packages loaded, 2041 targets configured).
INFO: Found 1 test target...
INFO: From CcCmakeMakeRule c-deps/libroach/include:

INFO: From CcCmakeMakeRule c-deps/libproj/include:

INFO: From CcConfigureMakeRule c-deps/libjemalloc/include:
Target //pkg/ccl/sqlproxyccl:sqlproxyccl_test up-to-date:
  bazel-bin/pkg/ccl/sqlproxyccl/sqlproxyccl_test_/sqlproxyccl_test

INFO: Elapsed time: 61.725s, Critical Path: 40.72s
INFO: 611 processes: 15 internal, 596 processwrapper-sandbox.
INFO: Build completed successfully, 611 total actions
//pkg/ccl/sqlproxyccl:sqlproxyccl_test                                   PASSED in 8.2s

INFO: Build completed successfully, 611 total actions

@rickystewart
Copy link
Collaborator

Works for me, thanks for working on this!

@darinpp
Copy link
Contributor Author

darinpp commented Apr 30, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 30, 2021

Build succeeded:

@craig craig bot merged commit fc86aa6 into cockroachdb:master Apr 30, 2021
@darinpp darinpp deleted the sqlproxyccl-bazel-fix branch May 3, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl/sqlproxyccl: broken tests in Bazel
3 participants