docgen: bump railroad diagram generation timeout to 120s #64430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ericharmeling
approved these changes
Apr 29, 2021
Yeah I prefer to use the JAR as well for stability but currently docgen will fail on our generated bnfs without a JAR. Figure its beneficial to also get this working. |
otan
reviewed
Apr 29, 2021
pkg/cmd/docgen/extract/extract.go
Outdated
| @@ -77,7 +78,8 @@ func GenerateRRNet(bnf []byte) ([]byte, error) { | |||
| v.Add("options", "factoring") | |||
| v.Add("options", "inline") | |||
|
|
|||
| resp, err := httputil.Post(context.TODO(), rrAddr, "application/x-www-form-urlencoded", strings.NewReader(v.Encode())) | |||
| httpClient := httputil.NewClientWithTimeout(120 * time.Second) | |||
There was a problem hiding this comment.
if you want something fancy you should make this a flag with flag.Duration :P
There was a problem hiding this comment.
Good call I think it's pretty straight forward to do this as well. Will update.
There was a problem hiding this comment.
Updated PTAL @otan
RichardJCai
force-pushed
the
change_diagram_gen_timeout_04292021
branch
from
49b83cb to
04f8ac3
Compare
Previously it was hardcoded to 3s timeout when using the HTTP api for either railroad generation or bnf generation. Now the user can pass a value via the --timeout flag to set a timeout for the HTTP apis. Default is 120s. Release note: None
RichardJCai
force-pushed
the
change_diagram_gen_timeout_04292021
branch
from
04f8ac3 to
dfcd8b7
Compare
ianjevans
approved these changes
May 3, 2021
otan
approved these changes
May 3, 2021
|
Thanks for the reviews! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some diagrams are too long to be generated in the current 3s. Bumping up to 120s for now since generating diagrams isn't exactly time sensitive.
Release note: None