ccl/sqlproxyccl: add basic login rate limiting #64305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andy-kimball
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Is the eventual plan to import this package from the cockroachdb repo into the managed-service repo, so that it doesn't exist in both places?
Reviewable status:
complete! 1 of 0 LGTMs obtained
Moves from the CC repo a package which performs basic login admission control to rate limit login attempts. Login attempts are rate limited based solely on source IP. Admission control is currently purely a local decision, but the package this interface defines could easily become the client-side for connection to a centralized service. Release note: None
Yes, this is the plan. |
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves from the CC repo a package which performs basic login admission
control to rate limit login attempts. Login attempts are rate limited
based solely on source IP. Admission control is currently purely a
local decision, but the package this interface defines could easily
become the client-side for connection to a centralized service.
Release note: None