Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: changefeedccl: Make kafka_sink_config a valid option. #63873

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

miretskiy
Copy link
Contributor

Backport 1/1 commits from #63857.

/cc @cockroachdb/release


Add kafka_sink_config to the list of allowed changefeed options.

Release Notes: None

@miretskiy miretskiy requested review from HonoreDB, a team and adityamaru and removed request for a team April 19, 2021 19:39
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@miretskiy miretskiy removed the request for review from adityamaru April 19, 2021 19:40
Copy link
Contributor

@HonoreDB HonoreDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @miretskiy)

Add `kafka_sink_config` to the list of allowed changefeed options.

Release Notes: None
@miretskiy miretskiy force-pushed the backport21.1-63857 branch from f419bb9 to cbdc6cd Compare April 20, 2021 11:35
@miretskiy miretskiy merged commit 90f3608 into cockroachdb:release-21.1 Apr 20, 2021
@miretskiy miretskiy deleted the backport21.1-63857 branch April 22, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants