pgwire,logpb,eventpb: various structured logging doc updates #63841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20210419-log
branch
2 times, most recently
from
4a9c4fd to
b85d025
Compare
|
friendly ping |
|
@rauchenstein could you review this as well? Thanks cc @taroface |
taroface
approved these changes
May 5, 2021
There was a problem hiding this comment.
LGTM, and I updated the logging docs PR to reflect the update to SQL_EXEC. Thank you!
Reviewed 1 of 1 files at r1, 5 of 5 files at r2, 3 of 3 files at r3.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @itsbilal and @rauchenstein)
Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
Release note (security update): Syntax errors in the HBA configuration in cluster setting `server.host_based_authentication.configuration` are now logged on the OPS channel.
The SQL_EXEC channel contains statement execution events (structured) and a copy of Go panics encountered during SQL execution (unstructured). Release note: None
The `SlowQuery` event only gets logged for full table scans if a certain cluster setting is set. This commit explains this. Release note: None
|
bors r=taroface |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit from #62629.
Fixes #63764.
Fixes #63762.
See individual commits for details.
cc @taroface