Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update the go version requirement for make #63837

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

knz
Copy link
Contributor

@knz knz commented Apr 19, 2021

Fixes #63837.

The builder image already requires go 1.15.10. This patch
modifies the check for a non-builder make command to require
at least the same version.

Release note: None

The builder image already requires go 1.15.10. This patch
modifies the check for a non-builder `make` command to require
at least the same version.

Release note: None
@knz knz requested review from otan and tbg April 19, 2021 10:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor Author

knz commented Apr 19, 2021

thank you

bors r=otan

@craig
Copy link
Contributor

craig bot commented Apr 19, 2021

Build failed:

@knz
Copy link
Contributor Author

knz commented Apr 19, 2021

unrelated flake (http deadlock - #63836)

bors r=otan

@craig
Copy link
Contributor

craig bot commented Apr 19, 2021

Build failed:

@knz
Copy link
Contributor Author

knz commented Apr 19, 2021

Flake: #63851. Waiting on #63852 to merge and will retry.

@knz knz mentioned this pull request Apr 19, 2021
@knz
Copy link
Contributor Author

knz commented Apr 19, 2021

bors r=otan

@craig
Copy link
Contributor

craig bot commented Apr 19, 2021

Build succeeded:

@craig craig bot closed this in 4dc05cc Apr 19, 2021
@craig craig bot merged commit 4dc05cc into cockroachdb:master Apr 19, 2021
@knz knz deleted the 20210419-govers branch April 19, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants