release-20.2: sql: ensure "promoted" temporary views are marked as such #63781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug whereby views which reference temp tables are created in the temporary schema but are not marked as being temporary. Usually this doesn't cause a lot of trouble. Problems arise when another session attempts to drop the database corresponding to the temp schema containing these views before they have been cleaned up. In that case, the `DROP DATABASE` command will observe an opaque `descriptor not found` error. Release note (bug fix): Fixed a bug which could cause errors in DROP DATABASE CASCADE when the database contains temporary views in other sessions which were not explicitly marked as TEMPORARY.
|
This change is |
arulajmani
approved these changes
Apr 16, 2021
complete! 1 of 0 LGTMs obtained
|
TFTR! |
|
@ajwerner should we "forward-port" the regression test in this commit to |
I don't believe this bug exists on master or 21.1. See #62281 (comment). |
|
Yes, but having the regression test on master and release-21.1 would be useful to prevent this issue indefinitely. |
|
Whoops missed the words "regression test". Yes, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug whereby views which reference temp tables are created
in the temporary schema but are not marked as being temporary. Usually this
doesn't cause a lot of trouble. Problems arise when another session attempts
to drop the database corresponding to the temp schema containing these views
before they have been cleaned up. In that case, the
DROP DATABASEcommandwill observe an opaque
descriptor not founderror.Fixes #62281.
Release note (bug fix): Fixed a bug which could cause errors in DROP DATABASE
CASCADE when the database contains temporary views in other sessions which
were not explicitly marked as TEMPORARY.