release-20.2: backupccl: cluster restore import and restore jobs as canceled #63765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pbardea
force-pushed
the
manual-backport-jobs
branch
2 times, most recently
from
6c195e1 to
68def5b
Compare
pbardea
changed the title
IMPORT and RESTORE may write non-transactionally, so their writes cannot be trusted to be included in every backup. As such, they should be restored in a reverting state to attempt to undo any of their untrusted writes. Release note (bug fix): IMPORT and RESTORE jobs are now restored as reverting so that they cleanup after themselves. Previously, some of the writes of the jobs while they were running may have been missed by backup.
pbardea
force-pushed
the
manual-backport-jobs
branch
from
68def5b to
b3151e7
Compare
ajwerner
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @dt)
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORT and RESTORE may write non-transactionally, so their writes cannot
be trusted to be included in every backup. As such, they should be
restored in a reverting state to attempt to undo any of their untrusted
writes.
Release note (bug fix): IMPORT and RESTORE jobs are now restored as
reverting so that they cleanup after themselves. Previously, some of the
writes of the jobs while they were running may have been missed by
backup.