cli: add notice about --global being experimental on demo startup #63515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
In addition to the release note, reworded the add node (which already errored beforehand), and adding a clause in RestartNode. Note there is no code path that allows a restart, since shutdown is required before a node restart. Release note (cli change): No longer support `\demo add/shutdown` on cockroach demo.
Release note: None
Release note (cli change): Added a note when starting up a --global demo cluster that it is experimental.
knz
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 2 of 2 files at r2, 1 of 1 files at r3.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajstorm)
|
bors r=knz TFTR! |
|
Build succeeded: |
|
🎉
…On Tue, Apr 13, 2021 at 7:34 AM craig[bot] ***@***.***> wrote:
Merged #63515 <#63515> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63515 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEMXVORD4SFOLEOKG2KJHETTIQT4HANCNFSM422KMOIA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #63469
See individual commits for details. Intended for backport for v21.1.1.