colexec: fix usage of incorrect type schema for external hash agg #63446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
We recently merged a change to the external hash aggregator to maintain ordering. This was done by planning an explicit sort after aggregation. However, a bug was introduced in which we were using the incorrect type schema for sort planning: namely, we used the "result types" for the aggregator stage (after a projection is applied), but we should have used the "output types" (the schema of what the aggregator outputs). Now this is fixed. Release note: None
yuzefovich
force-pushed
the
fix-hash-agg
branch
from
0d04f6e to
971bf24
Compare
rytaft
approved these changes
Apr 11, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently merged a change to the external hash aggregator to maintain
ordering. This was done by planning an explicit sort after aggregation.
However, a bug was introduced in which we were using the incorrect type
schema for sort planning: namely, we used the "result types" for the
aggregator stage (after a projection is applied), but we should have
used the "output types" (the schema of what the aggregator outputs). Now
this is fixed.
Fixes: #63430.
Fixes: #63431.
Fixes: #63432.
Fixes: #63433.
Fixes: #63434.
Fixes: #63435.
Fixes: #63436.
Fixes: #63437.
Fixes: #63438.
Fixes: #63439.
Fixes: #63440.
Fixes: #63441.
Fixes: #63442.
Fixes: #63443.
Release note: None