cli: don't call (raftpb.Entry).String #63298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likely due to golang/gogo proto incompatibilities around our use of the
`(gogoproto.nullable)` option, calling `.String()` on a `raftpb.Entry`
panics.
However, upstream at our currently vendored commit
578ffd578362a8962194c4c0c68c1a9824cf9ea3,
```
func TestFoo(t *testing.T) {
ent := pb.Entry{Term: 1, Index: 2}
_ = ent.String()
}
```
does not panic.
This commit adds a test documenting the undesired behavior and working
around it in `./cockroach debug raft-log` (and the other debug commands
that stringify log entries).
Found while investigating cockroachdb#61990.
Release note: None
|
This change is |
erikgrinaker
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
This is unfortunate. :/
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @tbg)
|
Has since been fixed, see #63299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely due to golang/gogo proto incompatibilities around our use of the
(gogoproto.nullable)option, calling.String()on araftpb.Entrypanics.
However, upstream at our currently vendored commit
578ffd578362a8962194c4c0c68c1a9824cf9ea3,
does not panic.
This commit adds a test documenting the undesired behavior and working
around it in
./cockroach debug raft-log(and the other debug commandsthat stringify log entries).
Found while investigating #61990.
Release note: None