sql: wrap typed Array within IndirectionExpr in ParenExpr #63271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a case that #63103 missed. When we have something like `ARRAY['a'::typ, 'b'::typ]`, we format it to `ARRAY['a'::typ, 'b'::typ]:::public.typ[]`. This causes issues if used in an `IndirectionExpr`, such as `ARRAY['a'::typ, 'b'::typ]:::public.typ[][1]`, as the `[1]` is interpreted as part of the type. This would result in errors when trying to use these expressions in default expressions. This patch checks for this specific case, and instead formats it as `(ARRAY['a'::typ, 'b'::typ]:::public.typ[])[1]`. Release note: None
|
This change is |
ajwerner
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @the-ericwang35)
rafiss
approved these changes
Apr 8, 2021
|
TFTRs! bors r=ajwerner,rafiss |
|
Build succeeded: |
This was referenced Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a case that #63103 missed.
When we have something like
ARRAY['a'::typ, 'b'::typ],we format it to
ARRAY['a'::typ, 'b'::typ]:::public.typ[].This causes issues if used in an
IndirectionExpr, such asARRAY['a'::typ, 'b'::typ]:::public.typ[][1], as the[1]is interpreted as part of the type.
This would result in errors when trying to use these
expressions in default expressions.
This patch checks for this specific case, and instead
formats it as
(ARRAY['a'::typ, 'b'::typ]:::public.typ[])[1].Release note: None