Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: deflake test with statement_timeout #63268

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

RaduBerinde
Copy link
Member

I saw a CI failure in this test, caused by the SHOW statement itself
hitting the 100ms timeout. This points to something being unreasonably
slow on the agent; but it is easy enough to increase this arbitrary
value.

Release note: None

I saw a CI failure in this test, caused by the `SHOW` statement itself
hitting the 100ms timeout. This points to something being unreasonably
slow on the agent; but it is easy enough to increase this arbitrary
value.

Release note: None
@RaduBerinde RaduBerinde requested a review from jordanlewis April 8, 2021 02:30
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)

@RaduBerinde
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 8, 2021

Build succeeded:

@craig craig bot merged commit 2c50690 into cockroachdb:master Apr 8, 2021
@RaduBerinde RaduBerinde deleted the lt-set-timeout branch April 8, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants