release-21.1: colexec: wrap DrainMeta with panic-catcher and protect columnarizer #63242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in some edge cases (like when a panic is encountered during `Operator.Init`) the metadata sources could have been uninitialized, so when we tried to drain them, we'd encounter a crash. In order to avoid that in the future, now all root components will wrap the draining with the panic-catcher. Additionally, we now protect the columnarizer in this case explicitly - if it wasn't initialized, it won't drain the wrapped processor in `DrainMeta`. Release note: None
|
This change is |
rytaft
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/2 commits from #63108.
/cc @cockroachdb/release
colexec: wrap DrainMeta with panic-catcher and protect columnarizer
Previously, in some edge cases (like when a panic is encountered during
Operator.Init) the metadata sources could have been uninitialized, sowhen we tried to drain them, we'd encounter a crash. In order to avoid
that in the future, now all root components will wrap the draining with
the panic-catcher. Additionally, we now protect the columnarizer in this
case explicitly - if it wasn't initialized, it won't drain the wrapped
processor in
DrainMeta.Fixes: #62514.
Release note: None