Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-21.1: sqlsmith;mutations: blitz to fix Postgres compare_test bugs #63029

Merged
merged 17 commits into from
Apr 5, 2021
Merged

release-21.1: sqlsmith;mutations: blitz to fix Postgres compare_test bugs #63029

merged 17 commits into from
Apr 5, 2021

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Apr 2, 2021

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

rafiss added 17 commits April 2, 2021 11:04
@rafiss
compare_test: check for backends being ready
7d2282c 
Release note: None
@rafiss
sql/rowenc: use CASE instead of IF() for random computed columns
8166e5c 
This allows the randomly create computed column definition to be
used against both CockroachDB and PostgreSQL.

Release note: none
@rafiss
compare_test: log name when attempting connection
00bb012 
This prevents an unused variable compilation error.

Release note: None
@rafiss
mutations: allow spatial types for Postgres
a308f62 
Release note: None
@rafiss
mutations: prevent context-dependent casts in Postgres
85f76a4 
Release note: None
@rafiss
mutations: don't allow box2d as a primary key for Postgres
1d3b506 
Also changed the interleaving setup so that it no longer tries to interleave
at all, since we are messing around with the PK now.

Release note: None
@rafiss
sqlsmith: ignore crdb_internal_mvcc_timestamp in postgres mode
c1d20c2 
Release note: None
@rafiss
sqlsmith: fix date arithmetic in postgres mode
7194982 
Release note: None
@rafiss
sqlsmith: ignore CockroachDB-specific functions in postgres mode
b0aadbe 
Release note: None
@rafiss
sqlsmith: ignore missing binops in postgres mode
bee0ad4 
Release note: None
@rafiss
sqlsmith: use INT4 args for functions in postgres mode
d5009df 
Release note: None
@rafiss
sqlsmith: use INT4 for Postgres BinOps that require it
8086ae1 
Release note: None
@rafiss
sqlsmith: don't ORDER/GROUP BY box2d in postgres mode
797b37f 
Release note: None
@rafiss
sqlsmith: fallback to constant args for aggregate functions
fe6c573 
It was a bug to fallback to using a non-aggregate function, since it
could result in a column being referenced from HAVING without being in
the GROUP BY or any aggregate functions.

Release note: None
@rafiss
mutations: handle tuple formatting difference in postgres
8b68c5d 
Release note: None
@rafiss
testutils: fix inspection of FK constraints
972036c 
Release note: None
@rafiss
compare_test: only use PostgresMutator in postgres test
2e38298 
Release note: None
@rafiss rafiss requested a review from otan April 2, 2021 15:04
@rafiss rafiss mentioned this pull request Apr 2, 2021
Closed
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit 11c5408 into cockroachdb:release-21.1 Apr 5, 2021
@rafiss rafiss deleted the backport21.1-62682-62706 branch April 5, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otan otan otan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafiss @cockroach-teamcity @otan