release-21.1: roachtest/follower-reads: adopt multi-region abstractions, add GLOBAL tables #62965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tables Fixes cockroachdb#59678. This commit expands the existing `follower-reads` roachtest into four variants: - follower-reads/survival=region/locality=global - follower-reads/survival=region/locality=regional - follower-reads/survival=zone/locality=global - follower-reads/survival=zone/locality=regional As the names indicate, these four variants are adapted to use the [new multi-region abstractions](https://www.cockroachlabs.com/docs/v21.1/multiregion-overview.html). Specifically, two of the variants configure the test database with a REGION survival goal while two of the variants configure the test database with a ZONE survival goal. The ZONE variant give us testing coverage for serving follower reads off of non-voting replicas, because only the primary region of the database will house voting replicas. The use of multi-region abstractions also extends to table locality settings. Two of the variants configure the table with a REGIONAL locality setting. This necessitates the use of stale reads to read from followers, as the test had been doing before. However, the other two variants configure the table with a GLOBAL locality setting. Because GLOBAL tables can serve non-stale reads from followers, the test can omit the `AS OF SYSTEM TIME follower_read_timestamp()` clause in these variants and test that GLOBAL tables provide low-latency consistent reads from all regions. Release note: None Release justification: testing only
Fixes cockroachdb#62240. Fixes cockroachdb#62196. Fixes cockroachdb#62067. Fixes cockroachdb#62065. Range splits after a table creation are async, so don't expect one immediately.
|
This change is |
aayushshah15
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
Closes #62854.
/cc @cockroachdb/release