sql: lease acquisition of OFFLINE descs may starve bulk operations #62959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @fqazi and @pbardea)
pkg/sql/catalog/lease/lease.go, line 1418 at r1 (raw file):
err2 := m.Release(desc) if err2 != nil {
nit: I'd prefere releaseErr to err2
|
bors r=ajwerner |
|
Build failed: |
|
bors r- |
Fixes: cockroachdb#61798 Previously, offline descriptors would never have their leases cached and they would be released once the reference count hit zero. This was inadequate because when attempting to online these tables again the lease acquisition could be pushed back by other operations, leading to starvation / live locks. To address this, this patch will allow the leases of offline descriptors to be cached. Release note (bug fix): Lease acquisitions of descriptor in a offline state may starve out bulk operations (backup / restore)
|
bors r=ajwerner |
|
Build failed (retrying...): |
|
Build succeeded: |
|
this one may need a backport on the 21.1 branch as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #61798
Previously, offline descriptors would never have their leases
cached and they would be released once the reference count hit zero.
This was inadequate because when attempting to online these tables
again the lease acquisition could be pushed back by other operations,
leading to starvation / live locks. To address this, this patch will
allow the leases of offline descriptors to be cached.
Release note (bug fix): Lease acquisitions of descriptor in a
offline state may starve out bulk operations (backup / restore)