colexecerror: catch panics from packages in sql/sem folder #62889
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
reviewed
Mar 31, 2021
There was a problem hiding this comment.
I think the key attribute of these packages is that they are stateless. Can you add a comment above the package exclusions explaining why they are safe to panic-catch?
Reviewable status:
complete! 1 of 0 LGTMs obtained
Previously, we would only catch panics from `sql/sem/tree` package. Recently sqlsmith encountered a crash because of a panic in `sql/sem/builtins` package, and I believe it is reasonable to catch panics from that package as well as from `sql/sem/transform`, so we will now be catching based on `sql/sem` prefix. Release note: None
|
Added a comment, please take a look. I feel like the comment is not entirely applicable to all of the packages, but in general should be true. |
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would only catch panics from
sql/sem/treepackage.Recently sqlsmith encountered a crash because of a panic in
sql/sem/builtinspackage, and I believe it is reasonable to catchpanics from that package as well as from
sql/sem/transform, so we willnow be catching based on
sql/semprefix.Addresses: #62846.
Release note: None