release-21.1: build: upgrade go to 1.15.10 #62873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
#62875 will fix the Bazel build failures. |
otan
approved these changes
Mar 31, 2021
rickystewart
force-pushed
the
backport21.1-62815
branch
from
dabd210 to
51a2f3f
Compare
|
rebase to fix the bazel thing |
|
ah, not sure how your review got trampled @otan, sorry :) |
Pick up a patch to a compiler bug (see cockroachdb#62521). * [ ] Adjust the Pebble tests to run in new version. * [x] Adjust version in Docker image ([source](./builder/Dockerfile)). * [x] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [x] Bump the version in `WORKSPACE` under `go_register_toolchains`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). * [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [ ] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [ ] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed. * [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh#L40-42)). * [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [ ] Adjust `GO_VERSION` in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) and ask the Developer Infrastructure team to deploy new images. Resolves cockroachdb#62809. Release note (general change): Upgrade the CRDB binary to Go 1.15.10.
rickystewart
force-pushed
the
backport21.1-62815
branch
from
51a2f3f to
a7855da
Compare
|
flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #62815.
/cc @cockroachdb/release
Pick up a patch to a compiler bug (see #62521).
WORKSPACEundergo_register_toolchains. You may need to bump rules_go.builder.shaccordingly (source).go-version-check.sh(source), unless bumping to a new patch release.go.mod. You may also need to rerunmake vendor_rebuildif vendoring has changed.bootstrap-debian.sh(source).golang:<old_version>andgo<old_version>).builder.dockerImageparameter in the TeamCityCockroachandInternalprojects.GO_VERSIONin the TeamCity agent image (setup script)and ask the Developer Infrastructure team to deploy new images.
Resolves #62809.
Release note (general change): Upgrade the CRDB binary to Go 1.15.10.