sql: fix ALTER PRIMARY KEY with virtual columns on the table #62843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
approved these changes
Mar 31, 2021
| CONSTRAINT "primary" PRIMARY KEY (new_pk ASC), | ||
| UNIQUE INDEX table_with_virtual_cols_id_key (id ASC), | ||
| FAMILY fam_0_new_pk (new_pk), | ||
| FAMILY fam_1_id (id) |
There was a problem hiding this comment.
seems like fam_1_id isn't expected
There was a problem hiding this comment.
hehe, this randomised family stuff man
Release note (bug fix): Fix a bug where ALTER PRIMARY KEY would fail if the table contained virtual columns.
|
bors r=rafiss |
|
Build failed: |
|
bors r=rafiss |
|
Build succeeded: |
|
Nice find, thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (bug fix): Fix a bug where ALTER PRIMARY KEY would fail if
the table contained virtual columns.