release-21.1: opt: allow casts in initial CTE expression #62824
Merged
+114
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#60560, we made the matching of types in UNIONs more strict. In the recursive CTE code, we don't allow adding casts to the initial expression, so the change caused us to regress in terms of supported queries. This change fixes this by allowing casts to the initial expression. Not sure why I didn't allow this from the get-go. Release note (bug fix): fixed "types cannot be matched for WITH RECURSIVE" error in cases where we can cast the type in the initial expression.
|
This change is |
mgartner
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #62808.
/cc @cockroachdb/release
In #60560, we made the matching of types in UNIONs more strict. In the
recursive CTE code, we don't allow adding casts to the initial
expression, so the change caused us to regress in terms of supported
queries.
This change fixes this by allowing casts to the initial expression.
Not sure why I didn't allow this from the get-go.
Release note (bug fix): fixed "types cannot be matched for WITH
RECURSIVE" error in cases where we can cast the type in the initial
expression.