release-20.2: ui: fix aggregation on txn details #62797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nathanstilwell
requested review from
nathanstilwell
and removed request for
a team
nathanstilwell
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @elkmaster)
|
The changes look good and testing locally looks solid. @elkmaster I'm going to look into this test failure in the morning. |
vladlos
force-pushed
the
upgrade-to-cluster-ui
branch
from
65c35a9 to
7a3da6f
Compare
in old version admin-ui-components we have known issue on txn datails page with duplications of stmns displayed on multinode clusters. as admin-ui-components is deprecated switched this dependency on relative version of cluster-ui. as 20.2 console db pointed to pretty old commit in yarn-vendored master-20.2 was created and contains corresponding changes for current pr. Release note (ui): fix duplicates of statements on transactions details page for multi-node clusters
nathanstilwell
force-pushed
the
upgrade-to-cluster-ui
branch
from
7a3da6f to
6478947
Compare
jordanlewis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in old version admin-ui-components we have known issue on txn
datails page with duplications of stmns displayed on multinode
clusters. as admin-ui-components is deprecated switched this dependency on relative version of cluster-ui.
as 20.2 console db pointed to pretty old commit in yarn-vendored
master-20.2 was created and contains corresponding changes for
current pr.
Release note (ui): fix duplicates of statements on transactions details page for multi-node clusters