lease: remove code from 20.1->20.2 migration #62579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
postamar
approved these changes
Mar 25, 2021
pkg/sql/catalog/lease/lease.go
Outdated
| func (m *Manager) watchForRangefeedUpdates( | ||
| ctx context.Context, s *stop.Stopper, db *kv.DB, descUpdateCh chan<- *descpb.Descriptor, | ||
| ) { | ||
| // watchForUpdates will watch either a rangefeeds on the system.descriptor |
ajwerner
force-pushed
the
ajwerner/remove-rangefeed-migration-code
branch
from
1348308 to
48e0887
Compare
In 20.1, rangefeeds were not unconditionally enabled on the descriptor table and so we had to poll for the migration. This code was pretty gross and I'm happy to excise it. Release note: None
ajwerner
force-pushed
the
ajwerner/remove-rangefeed-migration-code
branch
from
48e0887 to
1579a4c
Compare
ajwerner
commented
Mar 29, 2021
There was a problem hiding this comment.
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @fqazi)
|
Build succeeded: |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Jun 16, 2021
This version's use was removed in cockroachdb#62579. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 20.1, rangefeeds were not unconditionally enabled on the descriptor
table and so we had to poll for the migration. This code was pretty gross
and I'm happy to excise it.
Release note: None