roachtest: use 2-minute ramp times for YCSB workloads #62535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#62534 it was shown that it takes up to two minutes before we have good enough statistics to allocate appropriately sized batches. However, the YCSB workloads only had a 1-minute ramp time, which would skew the results as throughput would abruptly change when the statistics were updated during the test. This patch changes the ramp time for YCSB workloads to 2 minutes to make sure we have appropriate statistics before starting the actual test. Release note: None
|
This change is |
yuzefovich
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
FYI: not sure if you're aware, but we don't use the master version of roachtests when running them on old branches, so we'll need to backport this change too. (This was changed in the last 6 months.)
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
erikgrinaker
commented
Mar 24, 2021
There was a problem hiding this comment.
Thanks for the headsup!
Reviewable status:
|
bors r=yuzefovich |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #62534 it was shown that it takes up to two minutes before we have
good enough statistics to allocate appropriately sized batches. However,
the YCSB workloads only had a 1-minute ramp time, which would skew the
results as throughput would abruptly change when the statistics were
updated during the test.
This patch changes the ramp time for YCSB workloads to 2 minutes to make
sure we have appropriate statistics before starting the actual test.
Release note: None