Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo/geomfn: fix st_shortestline and st_longestline for ZM coords #62488

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

andyyang890
Copy link
Collaborator

Previously, we were appending the coords slice for the two endpoints,
which would result in incorrect behaviour when the geometry had
more than two dimensions.

Fixes #62319.

Release note: None

Previously, we were appending the coords slice for the two endpoints,
which would result in incorrect behaviour when the geometry had
more than two dimensions.

Release note: None
@andyyang890 andyyang890 requested a review from otan March 23, 2021 21:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan
Copy link
Contributor

otan commented Mar 23, 2021

please backport this when you're done!

@andyyang890
Copy link
Collaborator Author

bors r=otan

@craig
Copy link
Contributor

craig bot commented Mar 24, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 24, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Mar 24, 2021

Build succeeded:

@craig craig bot merged commit fb3fc30 into cockroachdb:master Mar 24, 2021
@andyyang890 andyyang890 deleted the fix_st_shortestline branch March 24, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spatial: index out of bounds with st_shortestline
3 participants