Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: set crdb_test, crdb_test_off build tags appropriately #62468

Merged
merged 1 commit into from
Mar 23, 2021
Merged

bazel: set crdb_test, crdb_test_off build tags appropriately #62468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# TODO(irfansharif): We should fold this into `dev` instead (#56965).

build --ui_event_filters=-DEBUG --define gotags=bazel
test --define gotags=bazel
build --ui_event_filters=-DEBUG --define gotags=bazel,crdb_test_off
test --define gotags=bazel,crdb_test
query --ui_event_filters=-DEBUG

try-import %workspace%/.bazelrc.user
2 changes: 1 addition & 1 deletion BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ load("@bazel_gazelle//:def.bzl", "gazelle")
#
# gazelle:prefix github.com/cockroachdb/cockroach
# gazelle:build_file_name BUILD.bazel
# gazelle:build_tags bazel
# gazelle:build_tags bazel,crdb_test,crdb_test_off

# Enable protobuf generation.
#
Expand Down
6 changes: 4 additions & 2 deletions pkg/sql/opt/memo/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,16 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
go_library(
name = "memo",
srcs = [
"check_expr_skip.go",
"check_expr.go",
"check_expr_skip.go", # keep
"constraint_builder.go",
"cost.go",
"expr.go",
"expr_format.go",
"expr_name_gen.go",
"extract.go",
"filters_expr_mutate_checker_skip.go",
"filters_expr_mutate_checker.go",
"filters_expr_mutate_checker_skip.go", # keep
"group.go",
"interner.go",
"logical_props_builder.go",
Expand Down
1 change: 1 addition & 0 deletions pkg/sql/opt/props/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ go_library(
"multiplicity.go",
"selectivity.go",
"statistics.go",
"verify.go",
"volatility.go",
],
importpath = "github.com/cockroachdb/cockroach/pkg/sql/opt/props",
Expand Down
1 change: 1 addition & 0 deletions pkg/util/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ go_library(
srcs = [
"constants.go",
"crdb_test_off.go",
"crdb_test_on.go", # keep
"every_n.go",
"fast_int_map.go",
"fast_int_set.go",
Expand Down