cli/sql: properly format different times and floats #62310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, the SQL shell would improperly format variants of timestamps (time, date) and mistakenly use the same format for 32-bit and 64-bit float. This patch corrects this. Release note (cli change): The SQL shell (`cockroach demo`, `cockroach sql`) now attempts to better format values that are akin to time/date, as well as floating-point numbers.
|
This change is |
otan
approved these changes
Mar 21, 2021
stevendanna
approved these changes
Mar 22, 2021
|
thanks! bors r=otan,stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29044.
Prior to this patch, the SQL shell would improperly format
variants of timestamps (time, date) and mistakenly
use the same format for 32-bit and 64-bit float.
This patch corrects this.
Release note (cli change): The SQL shell (
cockroach demo,cockroach sql) now attempts to better format values that are akin to time/date,as well as floating-point numbers.