sql: remove some remnants of the heuristics planner #62293
Conversation
|
This change is |
yuzefovich
force-pushed
the
create-table
branch
3 times, most recently
from
2ed7b41 to
398ffc1
Compare
yuzefovich
force-pushed
the
create-table
branch
from
398ffc1 to
f082460
Compare
| # Regression test for #34524. | ||
| query I | ||
| (SELECT NULL FROM t34524) EXCEPT (VALUES((SELECT 1 FROM t34524 LIMIT 1)), (1)) | ||
| ---- |
There was a problem hiding this comment.
nit: I think the pkg/sql/logictest/testdata/logic_test/union might be a better place for this since there are no explicit joins in the query. Really, pkg/sql/logictest/testdata/logic_test/set seems best, but most EXCEPT tests are currently in the union file...
The heuristic planner has been long gone, but some remnants still remain. The most notable change is to `createTableNode` where we needed to synthesize a row ID column in the HP. I also searched for "heuristic pl" in the code base and found a few other mentions which are also removed. Two more are still present since they didn't seem as trivial. Release note: None
yuzefovich
force-pushed
the
create-table
branch
from
f082460 to
ea6a557
Compare
There was a problem hiding this comment.
TFTRs!
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @yuzefovich)
pkg/sql/logictest/testdata/logic_test/join, line 1122 at r1 (raw file):
Previously, mgartner (Marcus Gartner) wrote…
nit: I think the
pkg/sql/logictest/testdata/logic_test/unionmight be a better place for this since there are no explicit joins in the query. Really,pkg/sql/logictest/testdata/logic_test/setseems best, but mostEXCEPTtests are currently in theunionfile...
Done.
|
Build failed (retrying...): |
|
Build succeeded: |
The heuristic planner has been long gone, but some remnants still
remain. The most notable change is to
createTableNodewhere we neededto synthesize a row ID column in the HP. I also searched for "heuristic
pl" in the code base and found a few other mentions which are also
removed.
Two more are still present since they didn't seem as trivial.
Release note: None