Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colbuilder: use correct processorID for wrapped filterers #62288

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Mar 20, 2021

We forgot to use the correct processorID when planning wrapped filterers
which resulted in stats from those processors to be always attributed to
a processor with ID = 0.

Release note: None (no stable release with this bug)

@yuzefovich yuzefovich requested review from RaduBerinde and a team March 20, 2021 04:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

We forgot to use the correct processorID when planning wrapped filterers
which resulted in stats from those processors to be always attributed to
a processor with ID = 0.

Release note: None (no stable release with this bug)
Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 22, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 22, 2021

Build succeeded:

@craig craig bot merged commit 27b4ab1 into cockroachdb:master Mar 22, 2021
@yuzefovich yuzefovich deleted the fix-filterer-id branch March 22, 2021 20:17
@rafiss rafiss added this to the 21.1 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants