sql: remove vectorize_row_count_threshold setting #62164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzefovich
requested review from
asubiotto,
a team and
dt
and removed request for
a team
|
This change is |
RaduBerinde
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
asubiotto
approved these changes
Mar 17, 2021
This commit removes `vectorize_row_count_threshold` session variable and the corresponding cluster setting. In 21.1 release these are set to 0 by default, and in 21.2 release that default behavior cannot be changed. This marks another step towards the start of deprecating the row-by-row execution engine. Release note (sql change): `sql.defaults.vectorize_row_count_threshold` cluster setting as well as corresponding `vectorize_row_count_threshold` session variable have been removed. From now on, CockroachDB will behave exactly as if these were set to 0 (last default value).
|
TFTRs! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes
vectorize_row_count_thresholdsession variable andthe corresponding cluster setting. In 21.1 release these are set to 0 by
default, and in 21.2 release that default behavior cannot be changed.
This marks another step towards the start of deprecating the row-by-row
execution engine.
Fixes: #53893.
Release note (sql change):
sql.defaults.vectorize_row_count_thresholdcluster setting as well as corresponding
vectorize_row_count_thresholdsession variable have been removed. From now on, CockroachDB will behave
exactly as if these were set to 0 (last default value).