Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding: bazelify stringer #62143

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

otan
Copy link
Contributor

@otan otan commented Mar 17, 2021

This one is a total hack. See comment for details.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan force-pushed the fix_bazel_stringer branch from 54173ab to b88212e Compare March 17, 2021 09:06
Copy link
Contributor

@alan-mas alan-mas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally is working! you totally rocks!

LGTM

srcs = [
"encoding.go",
],
outs = ["type_string.go"],

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this empty space is not needed it.

This one is a total hack. See comment for details.

Release note: None
@otan otan force-pushed the fix_bazel_stringer branch from b88212e to 2504594 Compare March 17, 2021 19:41
@otan
Copy link
Contributor Author

otan commented Mar 17, 2021

bors r=alan-mas

@craig
Copy link
Contributor

craig bot commented Mar 17, 2021

Build succeeded:

@craig craig bot merged commit 9a132fa into cockroachdb:master Mar 17, 2021
@irfansharif
Copy link
Contributor

🤮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants