multiregionccl: unskip TestMultiRegionAfterEnterpriseDisabled #62116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajstorm
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan)
|
bors r=ajstorm |
|
Build failed: |
|
hilarious, it failed! |
This seems to race:
```
WARNING: DATA RACE
Write at 0x00000bd3e950 by goroutine 38:
github.com/cockroachdb/cockroach/pkg/ccl/utilccl.TestingDisableEnterprise()
/go/src/github.com/cockroachdb/cockroach/pkg/ccl/utilccl/license_check.go:61 +0x59
github.com/cockroachdb/cockroach/pkg/ccl/multiregionccl_test.TestMultiRegionAfterEnterpriseDisabled()
/go/src/github.com/cockroachdb/cockroach/pkg/ccl/multiregionccl/multiregion_test.go:75 +0x48e
github.com/cockroachdb/cockroach/pkg/testutils/testcluster.(*TestCluster).Start()
/go/src/github.com/cockroachdb/cockroach/pkg/testutils/testcluster/testcluster.go:338 +0x8eb
github.com/cockroachdb/cockroach/pkg/testutils/testcluster.(*TestCluster).Start()
/go/src/github.com/cockroachdb/cockroach/pkg/testutils/testcluster/testcluster.go:295 +0x2dc
github.com/cockroachdb/cockroach/pkg/testutils/serverutils.StartNewTestCluster()
/go/src/github.com/cockroachdb/cockroach/pkg/testutils/serverutils/test_cluster_shim.go:210 +0x19b
github.com/cockroachdb/cockroach/pkg/ccl/multiregionccl/multiregionccltestutils.TestingCreateMultiRegionCluster()
/go/src/github.com/cockroachdb/cockroach/pkg/ccl/multiregionccl/multiregionccltestutils/testutils.go:50 +0x537
github.com/cockroachdb/cockroach/pkg/ccl/multiregionccl_test.TestMultiRegionAfterEnterpriseDisabled()
/go/src/github.com/cockroachdb/cockroach/pkg/ccl/multiregionccl/multiregion_test.go:56 +0x1c4
testing.tRunner()
/usr/local/go/src/testing/testing.go:1123 +0x202
Previous read at 0x00000bd3e950 by goroutine 918:
github.com/cockroachdb/cockroach/pkg/ccl/utilccl.CheckEnterpriseEnabled()
/go/src/github.com/cockroachdb/cockroach/pkg/ccl/utilccl/license_check.go:71 +0x54
github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvfollowerreadsccl.checkEnterpriseEnabled()
/go/src/github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvfollowerreadsccl/followerreads.go:75 +0xab
github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvfollowerreadsccl.checkFollowerReadsEnabled()
/go/src/github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvfollowerreadsccl/followerreads.go:82 +0x79
github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvfollowerreadsccl.canSendToFollower()
/go/src/github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvfollowerreadsccl/followerreads.go:127 +0x64
github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).sendToReplicas()
/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord/dist_sender.go:1778 +0x441
```
This is fixed by loading the value with atomic.
Release note: None
Relevant fixes are now committed. Release note: None
|
bors r=ajstorm |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant fixes are now committed.
Resolves #61163
Release note: None