Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: perform bazel clean --expunge on make clean #62009

Merged
merged 1 commit into from
Mar 22, 2021
Merged

build: perform bazel clean --expunge on make clean #62009

merged 1 commit into from
Mar 22, 2021

Conversation

rickystewart
Copy link
Collaborator

Release note: None

@rickystewart rickystewart requested a review from rail March 15, 2021 14:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

rail
rail approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

ajwerner
ajwerner approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@rickystewart
Copy link
Collaborator Author

bazel isn't installed in every context from which we run make clean, so I put this behind a conditional.

@rickystewart
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 22, 2021

Build succeeded:

@craig craig bot merged commit 7899744 into cockroachdb:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

@rail rail rail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickystewart @cockroach-teamcity @rail @ajwerner