Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: fix json_extract_path_text NULL bug #61912

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 12, 2021

If a null JSON is returned, then the text representation is a nil
pointer, which was not handled correctly.

No release note since this bug only exists in non-released versions.

Release note: None

@rafiss rafiss requested review from RichardJCai and a team March 12, 2021 17:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

If a null JSON is returned, then the text representation is a nil
pointer, which was not handled correctly.

No release note since this bug only exists in non-released version.

Release note: None
@rafiss rafiss force-pushed the null-json-extract branch from 9ba3f44 to eed2c7a Compare March 12, 2021 22:31
@rafiss
Copy link
Collaborator Author

rafiss commented Mar 12, 2021

tftr!

bors r=RichardJCai

@craig
Copy link
Contributor

craig bot commented Mar 12, 2021

Build succeeded:

@craig craig bot merged commit 1b6c7f9 into cockroachdb:master Mar 12, 2021
@rafiss rafiss deleted the null-json-extract branch March 15, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants