sql: add back references for user defined types in expressions #61878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to #59864. Previously, a change was introduced to store sequences used in DEFAULT expressions to be referenced by their IDs instead of their names, to allow sequence renaming. In this patch, we want to do something similar by rewriting sequence references in views to be referenced by their IDs. This allows sequences used in views to be renamed. Release note (sql change): reference sequences used in views by their IDs to allow these sequences to be renamed.
Fixes #59019. Previously, we tracked back references for user-defined types when they appear as the type for columns (or used in array or alias types). However, we did not track them when they occur inside of expressions or view statements. This patch addresses this by tracking user-defined types inside of expressions and view statements. Release note: None
|
This change is |
|
Closing in favour of #62096 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59019.
Previously, we tracked back references for user-defined types
when they appear as the type for columns (or used in array
or alias types). However, we did not track them when they
occur inside of expressions or view statements.
This patch addresses this by tracking user-defined types
inside of expressions and view statements.
This is rebased on #61439 since it shares the same
view query walking logic implemented in that PR, which is
why it's massive right now.
Release note: None