sql: Add CREATE JOINTOKEN statement, gated behind feature flag #61810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the generation of join tokens bypassed the certificate manager when loading CA certificates. This change updates that code path and associated tests to use the certificate manager, to make testing easier. Release note: None.
|
This change is |
itsbilal
force-pushed
the
create-join-token-stmt
branch
from
f107efa to
a90a962
Compare
Adds a CREATE JOINTOKEN statement for use in TLS auto-joins. This statement, when run on a self-hosted single-tenant Cockroach node, creates and returns a new join token. This join token can then be copy-pasted to new nodes and used to give them the set of certificates for secure auto TLS initialization. See RFC cockroachdb#51991. Part of cockroachdb#60632. Release justification: New code path, gated behind an experimental feature flag. Release note: None.
itsbilal
force-pushed
the
create-join-token-stmt
branch
from
a90a962 to
89f1c2f
Compare
|
I'm going to fold this PR into #62053; makes more sense to just update one PR instead of two, as all of these changes are related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CREATE JOINTOKEN statement for use in TLS auto-joins.
This statement, when run on a self-hosted single-tenant
Cockroach node, creates and returns a new join token. This
join token can then be copy-pasted to new nodes and used
to give them the set of certificates for secure auto TLS
initialization.
See RFC #51991. Part of #60632.
Release justification: New code path, gated behind an
experimental feature flag.
Release note: None.