kvserver: Replace createTestStore with TestServer #61644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With multiTestContext gone, we cleanup the rest of the code in client_test and remove the redundant createTestStore paradigm in favor of TestServer. Release justification: Test clean-up, does not affect production code: Release note: None
|
This change is |
|
TFTR! |
|
Build succeeded: |
lunevalex
added a commit
to lunevalex/cockroach
that referenced
this pull request
Mar 11, 2021
Fixes cockroachdb#54646 PR cockroachdb#61644 introduced a bug into the TestEagerReplication test. Using a single TestServer sets the default zone config to require only one replica, which means the split in this test does not trigger a replication attempt. This PR sets the PartOfCluster parameter on the TestServer to disable that behavior. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Mar 15, 2021
61847: kvserver: fix TestEagerReplication r=lunevalex a=lunevalex Fixes #54646 PR #61644 introduced a bug into the TestEagerReplication test. Using a single TestServer sets the default zone config to require only one replica, which means the split in this test does not trigger a replication attempt. This PR sets the PartOfCluster parameter on the TestServer to disable that behavior. Release note: None Co-authored-by: Alex Lunev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiTestContext gone, we cleanup the rest of the code
in client_test and remove the redundant createTestStore paradigm
in favor of TestServer.
Release justification: Test clean-up, does not affect production code:
Release note: None