sql: remove connect privilege warning

[RichardJCai]

sql: remove connect privilege warning

Release justification: No functionality, removing warning
Release note: None

Resolves #61560

[cockroach-teamcity]

This change is 

[rafiss]

lgtm! thoughts on giving the admin role the connect privilege?

[RichardJCai]

lgtm! thoughts on giving the admin role the connect privilege?

admin role should have connect privilege already as it's has ALL when a new db is created.

However it does not for the system db though as admin is only given GRANT/SELECT on it. We should give it CONNECT though, I'll open a separate PR for it.

I think we also need a migration to give CONNECT to admin for system dbs created before 21.1. Thoughts?

[RichardJCai]

Thanks for the review!
bors r=rafiss

[RichardJCai]

Wait oops, I'll wait for CI to pass first
bors r-

[craig]

Canceled.

[RichardJCai]

bors r=rafiss

[craig]

Build failed:

• GitHub CI (Cockroach)

[RichardJCai]

bors r=rafiss

[rafiss]

I think we also need a migration to give CONNECT to admin for system dbs created before 21.1. Thoughts?

Hmm yes I suppose we should. I guess if it's annoying to do we can always push it off until we decide to enforce CONNECT privilege rules. lol or maybe we should just hardcode every role/user to have CONNECT privilege and make it impossible to revoke....

[craig]

Build succeeded:

• GitHub CI (Cockroach)

[RichardJCai]

I think we also need a migration to give CONNECT to admin for system dbs created before 21.1. Thoughts?

Hmm yes I suppose we should. I guess if it's annoying to do we can always push it off until we decide to enforce CONNECT privilege rules. lol or maybe we should just hardcode every role/user to have CONNECT privilege and make it impossible to revoke....

I don't think it would be annoying to do the migration, I wouldn't say it's urgent or necessary as of now as CONNECT only allows users to see metadata and admin can already see metadata on the system database anyway.