kvprober: add metrics to the registry & catalog #61524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit adds the kvprober metrics to the registry so they are exported at the prometheus endpoint and tracked in CRDB's time-series DB. This commit also adds the kvprober metrics to the catalog since that is required by a unit test. Release justification: Auxiliary system that is off by default. Release note: None.
joshimhoff
force-pushed
the
export_the_metrics_from_kvprober
branch
from
85324ec to
0dd1e55
Compare
joshimhoff
changed the title
tbg
approved these changes
Mar 5, 2021
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make joshimhoff a reviewer |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61074
kvprober: add metrics to the registry & catalog
This commit adds the kvprober metrics to the registry so they are
exported at the prometheus endpoint and tracked in CRDB's time-series
DB. This commit also adds the kvprober metrics to the catalog since
that is required by a unit test.
Release justification: Auxiliary system that is off by default.
Release note: None.